Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tidy ups #28

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Small tidy ups #28

merged 3 commits into from
Nov 2, 2023

Conversation

connec
Copy link
Member

@connec connec commented Nov 2, 2023

  • 4a9a99c refactor: use in-memory sqlite for tests and examples

    This avoids having to manage temporary files, and lets us drop the
    tempfile dev dependency.

  • 2e62b8c refactor!: replace sqlx_impls macro with blanket impl

    Less macros, less problems? This also makes the crate easier to use with
    other databases (e.g. custom ones).

    This could probably technically be a breaking change in some situations,
    e.g. if a specific implementation was provided for a custom
    sqlx::Database type.

    BREAKING CHANGE: The blanket impl will conflict with any explicit impls
    of sqlx::Executor on Tx<_>.

  • f6f43db refactor: convert Tx from a tuple struct

    Named fields are generally a bit clearer for structs with multiple
    fields.

This avoids having to manage temporary files, and lets us drop the
`tempfile` dev dependency.
Less macros, less problems? This also makes the crate easier to use with
other databases (e.g. custom ones).

This could probably technically be a breaking change in some situations,
e.g. if a specific implementation *was* provided for a custom
`sqlx::Database` type.

BREAKING CHANGE: The blanket impl will conflict with any explicit impls
of `sqlx::Executor` on `Tx<_>`.
Named fields are generally a bit clearer for structs with multiple
fields.
@connec connec merged commit 5957c32 into master Nov 2, 2023
19 checks passed
@connec connec deleted the tidy branch November 2, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant