Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanups. #519

Merged
merged 5 commits into from
May 2, 2023
Merged

Small cleanups. #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0912463
Small cleanups.
davidlehn Apr 20, 2023
b9b0758
Update GitHub actions versions.
davidlehn Apr 27, 2023
5d803fb
Test on Node.js 20.x.
davidlehn Apr 27, 2023
5788ea8
Use Node.js 18.x for GitHub actions.
davidlehn Apr 27, 2023
20e2016
Use Node.js 16.x for webpack related actions.
davidlehn Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [16.x]
node-version: [18.x]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm install
Expand All @@ -23,11 +23,11 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [14.x, 16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Install
Expand All @@ -44,9 +44,9 @@ jobs:
node-version: [16.x]
bundler: [webpack, browserify]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Install
Expand All @@ -64,9 +64,9 @@ jobs:
matrix:
node-version: [16.x]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm install
Expand All @@ -78,11 +78,11 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [16.x]
node-version: [18.x]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Install
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
and identifiers.
- Skip test with 'U' escapes. Will enable when [rdf-canonize][] dependency is
updated.
- Test on Node.js 20.x.

## 8.1.1 - 2023-02-25

Expand Down
7 changes: 3 additions & 4 deletions lib/expand.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ async function _expandObject({
}
return v;
}),
{propertyIsArray: options.isFrame});
{propertyIsArray: !!options.isFrame});
continue;
}

Expand Down Expand Up @@ -775,8 +775,7 @@ async function _expandObject({

expandedValue = await api.expand({
activeCtx,
activeProperty:
'@reverse',
activeProperty: '@reverse',
element: value,
options
});
Expand Down Expand Up @@ -881,7 +880,7 @@ async function _expandObject({
});
} else {
// recurse into @list or @set
const isList = (expandedProperty === '@list');
const isList = expandedProperty === '@list';
if(isList || expandedProperty === '@set') {
let nextActiveProperty = activeProperty;
if(isList && expandedActiveProperty === '@graph') {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"lib/**/*.js"
],
"dependencies": {
"@digitalbazaar/http-client": "^3.2.0",
"@digitalbazaar/http-client": "^3.4.1",
"canonicalize": "^1.0.1",
"lru-cache": "^6.0.0",
"rdf-canonize": "^3.0.0"
Expand Down
Loading