Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump http-client version to 4.1.1 #560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RinkeHoekstra
Copy link

The package was still relying on an older 3.x version of http-client that depended on a version of ky that required ky-universal which causes issues as it has a top-level await. The latest version of ky no longer has this dependency, and http-client no longer depends on this old version since digitalbazaar/http-client@895bdd2 (in Sept. 2023).

The package was still relying on an older 3.x version of http-client that depended on a version of `ky` that required `ky-universal` which causes issues as it has a top-level await. The latest version of `ky` no longer has this dependency.
@RinkeHoekstra
Copy link
Author

I ran the tests and can confirm that coverage is equivalent with the previous version of http-client:

=============================== Coverage summary ===============================
Statements   : 93.71% ( 2849/3040 )
Branches     : 90.8% ( 2419/2664 )
Functions    : 93.54% ( 174/186 )
Lines        : 93.63% ( 2796/2986 )
================================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant