Handle correctly if no assets are to be released #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
sarahsporck,
ztefanie,
f1sh1918 and
LeandraH
as code owners
steffenkleinle
force-pushed
the
handle-no-assets
branch
from
3dc4072
to
e9c0f57
Compare
|
This fixes digitalfabrik/entitlementcard#1521. Instead of passing a parameter to define which assets should be uploaded, I chose to just made the upload more robust and correctly handle if an empty list of files is passed. I tested this here: https://app.circleci.com/pipelines/github/digitalfabrik/entitlementcard/6029/workflows/38c8d3dd-911f-4e2c-a475-52322ab9df01/jobs/43140 |
f1sh1918
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no assets are to be released and therefore
files === '', the github release assets commands fails as it tries to upload the file with the path''. Therefore gracefully return without doing anything if no assets are to be released.Fixes: digitalfabrik/entitlementcard#1521