Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sorting store list #1487

Open
Docmale opened this issue Jun 6, 2024 · 7 comments · May be fixed by #1560
Open

Improve sorting store list #1487

Docmale opened this issue Jun 6, 2024 · 7 comments · May be fixed by #1560
Assignees
Labels

Comments

@Docmale
Copy link

Docmale commented Jun 6, 2024

Is your feature request related to a problem? Please describe.
As a user i want to sort the store item either alphabetically or by distance. In the current implementation the sorting is not clear and can not be changed

Describe the solution you'd like

  • Indicate in the headline of the store list (currently "Suchergebnisse" ) whether its sorted alphabetically or by distance by adding the particular label
  • Show the FAB button (that only will be displayed once after permitting location) permanently.
  • Sort the store list by default alphabetically if location permission is not given
  • Sort the store list by store distance if location permission is given
  • Depending on which sorting is applied, give the user the ability with the FAB button to change the sorting

Additional context
Add any other context or screenshots about the feature request here.

@Docmale Docmale added the Bug Something isn't working label Jun 6, 2024
@f1sh1918 f1sh1918 added prio: high Issue must be solved within the next weeks. and removed prio: high Issue must be solved within the next weeks. labels Jun 6, 2024
@f1sh1918
Copy link
Contributor

f1sh1918 commented Jun 6, 2024

For me the button only disapears if it was clicked once.
I agree that it might be confusing that there is no "indicator" which sorting is used.
I think we should sort them automatically nearby if user location is available and alphabetically if user location is disabled and indicate the sorting somewhere

@f1sh1918 f1sh1918 assigned f1sh1918 and unassigned f1sh1918 Jun 24, 2024
@f1sh1918
Copy link
Contributor

f1sh1918 commented Jul 2, 2024

i think if we implement option 2 an option could be.

  1. Default label for search results "Suchresultate (alphabetisch sortiert)
  2. Click on in meiner Nähe suchen
  3. The label "Suchresultate" will change to "Suchresultate (in der Nähe)
  4. FAB Button changes to "Alphabetisch suchen"
  5. Click on it sorting changes to default and label changes to 1.

What do you think about that @Docmale , @ztefanie , @michael-markl and @seluianova
I could also ask toni for help

@michael-markl
Copy link
Member

Yeah it's a tough one, because (as far as I can see) there's really no reason to sort alphabetically except if there is no location available. so having a huge button just for sorting Alphabetically seems bad to me.

@michael-markl michael-markl removed the Bug Something isn't working label Jul 2, 2024
@michael-markl
Copy link
Member

I removed the bug flag because it's not a bug (the button only displays if the location permission was not given at the time of app startup), but I admit it might be confusing to the user

@f1sh1918
Copy link
Contributor

f1sh1918 commented Jul 2, 2024

Maybe we ask @hauf-toni for her opinion

@hauf-toni
Copy link

Sorry for my late reply, here are my thoughts on this:

If the user location is available, we should sort the results by proximity automatically, if the user location is not available, we should sort the results alphabetically.

We should use a FAB with the label "Sort by Distance" if currently sorted alphabetically, when the user clicks this button, the results should be sorted by proximity, we change the label to "Sort Alphabetically". We should also display an indicator above the list, showing the current sorting method: "Search Results (Alphabetically Sorted)" or "Search Results (By Proximity)".

@f1sh1918 f1sh1918 changed the title Near by button vanishes Improve sorting store list Jul 25, 2024
@f1sh1918 f1sh1918 added the Task label Jul 25, 2024
@f1sh1918
Copy link
Contributor

@hauf-toni thx for your input. I updated the task description and the task is ready to go

@steffenkleinle steffenkleinle self-assigned this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

5 participants