1487: Allow switching of sorting mode for store list #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
f1sh1918,
ztefanie and
seluianova
as code owners
steffenkleinle
commented
Aug 2, 2024
| ) | ||
| // Returning a Container() instead of null avoids animations | ||
| : Container(), | ||
| floatingActionButton: FloatingActionMapBar( |
There was a problem hiding this comment.
Moving this check inside of FloatingActionMapBar was necessary to have enough space for the snackbar. Let me know if there are better ways to achieve this.
There was a problem hiding this comment.
i couldn't reproduce an issue here with old implementation. If the snackbar is overlapping for a short moment i don't see a problem. Maybe you can add a screenshot or video what the problem is here
There was a problem hiding this comment.
Without this, I just get the following error and no snackbar is shown:
steffenkleinle
force-pushed
the
1487-store-list-sorting
branch
from
0e25de8
to
345cc06
Compare
f1sh1918
reviewed
Aug 5, 2024
steffenkleinle
force-pushed
the
1487-store-list-sorting
branch
from
fdf450f
to
ec715ad
Compare
f1sh1918
reviewed
Aug 7, 2024
f1sh1918
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Improve sorting for store list by allowing to switch the sorting mod and giving additional information.
Proposed changes
Side effects
None.
Resolved issues
Fixes: #1487.