1507: Mobile scanner does not recognize barcodes

[f1sh1918]

Short description

Some android cameras don't recognize barcodes due to some upstream android camera issues.
This seem to be related to the defaultCamera resolution each device uses
juliansteenbakker/mobile_scanner#698
Its not that easy to detect which cameras may be issued to not apply this on all android devices.

Proposed changes

• provide a fixed camera resolution for specific android models

Side effects

• aspect ratio is not correct. so we can discuss if this is good enough, because it looks ugly
• i played around with the values but didn't find a working solution with correct aspect ratio so far

Resolved issues

Related: #1507

Note

I'm not sure if we should set the cameraResolution to all android devices because it looks ugly. But its also difficult to maintain particular models, so let me know what you think. We could keep the issue open if new devices will be reported.

Testing (dev only)

This bugfix is only testable with the particular device, but you can just check if the controller applies, if you add your model to devicesWithoutQRCodeDetection list and check if the resolution of the camera changes

[f1sh1918]

not sure how i can avoid defining different controllers twice since cameraResolution has no setter to change it
I hope i could extend it somehow just by cameraResolution

[michael-markl]

I am not entirely sure if it works, but you could make the _controller non-final and simply overwrite if/once we detect it is a problematic device (instead of setting the _hasCameraIssues flag).

[f1sh1918]

That does not work

[michael-markl]

Looks good (enough) to me :D Let's see if this fixes it for the reports that we got.

If you have tested on a separate device and this should be mergable I think :D

[f1sh1918]

Looks good (enough) to me :D Let's see if this fixes it for the reports that we got.

If you have tested on a separate device and this should be mergable I think :D

Yes since i adjusted some minor things, i will test it today again with the real device

[f1sh1918]

@michael-markl i just tested it again and realized that this implementation needed a future builder to handle async functions in the initState
Not very nice to need so much additional code just for async functions in initState but i think its not avoidable.
Without the changed state will not be recognized from the widget
Some good infos initState and StateManagement in flutter
https://www.dhiwise.com/post/the-role-of-flutter-linitstate-in-state-management