-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1416: Create endpoint for user data #1528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seluianova
requested review from
steffenkleinle,
f1sh1918 and
ztefanie
as code owners
July 3, 2024 13:59
f1sh1918
reviewed
Jul 3, 2024
.../kotlin/app/ehrenamtskarte/backend/migration/migrations/V0013_CreateUserEntitlementsTable.kt
Outdated
Show resolved
Hide resolved
seluianova
force-pushed
the
1416-create-endpoint-for-user-data
branch
from
July 3, 2024 14:08
05729e7
to
db58bde
Compare
…ate-endpoint-for-user-data # Conflicts: # backend/src/main/kotlin/app/ehrenamtskarte/backend/migration/migrations/MigrationsRegistry.kt
f1sh1918
reviewed
Jul 3, 2024
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/webservice/UserImportHandler.kt
Outdated
Show resolved
Hide resolved
f1sh1918
reviewed
Jul 3, 2024
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/webservice/UserImportHandler.kt
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/database/Schema.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/database/Schema.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/webservice/UserImportHandler.kt
Show resolved
Hide resolved
… project is ready to go live
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/webservice/UserImportHandler.kt
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/webservice/UserImportHandler.kt
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/database/Schema.kt
Outdated
Show resolved
Hide resolved
…te and endDate fields
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/webservice/UserImportHandler.kt
Show resolved
Hide resolved
seluianova
force-pushed
the
1416-create-endpoint-for-user-data
branch
from
July 9, 2024 13:34
43acd1f
to
0a2c6b2
Compare
…ate-endpoint-for-user-data # Conflicts: # backend/src/main/kotlin/app/ehrenamtskarte/backend/migration/TablesRegistry.kt
All the comments have been addressed |
seluianova
force-pushed
the
1416-create-endpoint-for-user-data
branch
from
July 23, 2024 10:28
7507cc8
to
1e25ade
Compare
f1sh1918
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good implementation. Tested with postman. 👍
There is just one error to catch i think for revoked.
I'm not happy with the naming of the table tbh.
Added a proposal
backend/src/main/kotlin/app/ehrenamtskarte/backend/migration/TablesRegistry.kt
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/webservice/UserImportHandler.kt
Outdated
Show resolved
Hide resolved
f1sh1918
reviewed
Jul 23, 2024
backend/src/main/kotlin/app/ehrenamtskarte/backend/userdata/webservice/UserImportHandler.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Fischer <[email protected]>
seluianova
force-pushed
the
1416-create-endpoint-for-user-data
branch
from
July 23, 2024 14:51
a2a484c
to
94f6d43
Compare
f1sh1918
reviewed
Jul 24, 2024
.../kotlin/app/ehrenamtskarte/backend/migration/migrations/V0014_CreateUserEntitlementsTable.kt
Outdated
Show resolved
Hide resolved
Tested the import again. everything fine from my side @seluianova |
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Create an http entpoint for Koblenz project to import user data
Proposed changes
Questionable items:
I decided to create a POST endpoint instead of PUT because:
As I see it, PUT is typically used to update or create the target resource indicated in the URI. Like, PUT /user/{id}, for example.
But in our case it's more like a procedure call and in such case IMO it's more common to use POST.
But if it's already agreed upon, let me know, and I'll just change it to PUT.
I named the table UserEntitlements because I think it will be more accurate than just Users or UserData.
But feel free to object.
I named the column 'revoked' instead of 'invalid', because 'valid' sounds like data validity to me.
But feel free to object (2)
Not included:
Resolved issues
Fixes: #1416
Testing
CSV data example: