-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1318: Setup backend test database #1536
Conversation
c1e2e38
to
64ed529
Compare
64ed529
to
f49e1eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tested on MacOS
Just one question. How can i trigger all tests at once?
Just found out how to trigger every single one.
The test execution should be added to circle ci check_backend
even these are only temporary tests.
Nicely done :) 👍
@f1sh1918 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i think everything should be fine.
gradle test
does not work for because of some jvm issue but that should rely on my local configuration
Have to fix that
But in intelliJ test container and tests work
@f1sh1918 try gradlew instead of gradle, it means “gradle wrapper” |
@ztefanie could you please also check that you can run the new tests locally? |
maybe @steffenkleinle can test it, since steffi will be on vacation |
doesn't help. its my local jvm config. nevermind Update: Fixed my jvm installation @seluianova works fine now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works for me!
Short description
To add integration tests for the backend (#1532), we need to setup a database.
In my opinion, using test containers library is the most convenient way to implement that.
Proposed changes
Add IntegrationTest base class, where database setup is performed.
To add new tests that require a database, new test classes must extend the IntegrationTest class.
Side effects
Would be nice to check if everything works on different OS.
I have only tested it on Ubuntu 22.04.4 LTS.
Resolved issues
Fixes: #1318