Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2940: Replace office icon #20

Draft
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

steffenkleinle
Copy link
Member

No description provided.

@steffenkleinle steffenkleinle marked this pull request as draft October 16, 2024 09:49
@steffenkleinle
Copy link
Member Author

steffenkleinle commented Oct 16, 2024

Probably @f1sh1918 as you have worked the most with this:
Why is it required to have one icon per color for our map style? As far as I can see, maki editor and the resulting iconset.json set the color automatically already 🙈

I am currently working on digitalfabrik/integreat-app#2940

There are also a lot of changes I did not do, is this to be expected?

Furthermore, I realized that the multipoi icon is only present in one color (green)?

@f1sh1918
Copy link
Contributor

f1sh1918 commented Oct 17, 2024

Probably @f1sh1918 as you have worked the most with this: Why is it required to have one icon per color for our map style? As far as I can see, maki editor and the resulting iconset.json set the color automatically already 🙈

I am currently working on digitalfabrik/integreat-app#2940

There are also a lot of changes I did not do, is this to be expected?

Furthermore, I realized that the multipoi icon is only present in one color (green)?

Not sure if got your question right?
In the end an iconsprite with different icon names will be generated. Each icon needs an unique name to be addressable. Since you can not change the colors there each icon has to be present in every color that is needed. via icon name and hexcode it can be addressed in the frontend.
Maybe what you expected is that you choose an icon in the frontend code and set there the color that is required. As far as i tested this does not work.
How do you want to address an icon with a particular color then? We get the icon und color from the backend that should be used on the map. If you have a better idea let me know.

The multipoi icon is only needed in gray afaics and you shouldn't change it to green.

You will not be able to address the office icon in different colors now. We will get from the backend _ and have to address it because they may choose different colors for that icon in the cms so please provide the icon in all available colors

I would just keep the existing svgs that shouldn't be changed
since they work. maybe there was an update in the maki editor and the svgs now have a different output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants