-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
983: Upgrade dependencies #1013
Conversation
45bb136
to
aa5cc47
Compare
76f6c59
to
ba62b06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Android, works as expected 🚀
Thanks for updating 🙏
src/routes/write-exercise/services/AbstractWriteExerciseService.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thank you! Tested on real iOS
There were a few issues that I had to solve to get it running on iOS (I'll push them in a minute):
- Update cocoapods (Recent visionos change is breaking ios builds getsentry/sentry-react-native#3547)
- Update permissions handling (https://github.com/zoontek/react-native-permissions/releases/tag/3.9.0)
Would appreciate someone else checking on iOS @ztefanie @f1sh1918
Could be due to outdated OS (and therefore xcode version) of my mac. |
leandras approve should be sufficient? @steffenkleinle |
Since I now wrote part of the code, I feel like another person should test the part that I wrote. But that might be paranoia on my part :) |
I am fine with both, will be tested by Martin before a production release again anyway right? Also @LeandraH I think you just made sure that dependencies are correctly picked up for iOS, you didn't change any user-visible code. So I think we could merge this from my perspective. |
Works for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ios
Short description
Upgrade most dependencies.
Proposed changes
getGalleryPermission()
ByRole
queries, should be fixed in react-native upgrade (Upgrade react-native #1010)Separate PR for an upgrade of prettier: #1014.
Created separate tickets for upgrading
Tickets already existing for upgrades/migrations:
Ticket for unmaintained dependencies:
#1015.
Side effects
Hopefully none.
Resolved issues
Fixes: #983.