LBAAS: add lb ipv6 address as ingress #778
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvasilevsky
commented
Nov 27, 2024
•
jvasilevsky
commented
- add lb ipv6 address as ingress
- update godo version
jvasilevsky
force-pushed
the
jvasilevsky/LBAAS-add-lb-ipv6-as-ingress
branch
from
0a3b479
to
91f0b3b
Compare
bbassingthwaite
approved these changes
Nov 27, 2024
m3co-code
reviewed
Nov 27, 2024
| - #760 - @jvasilevsky - LBAAS: add ipv6 field to loadbalancer model | ||
| - #759 - @imaskm - Add reserved ipv6 changes as Beta | ||
| - #758 - @dvigueras - Add Rules field to create Databases with Firewall Rules | ||
| - #751 - @blesswinsamuel - APPS-9766 Add method to restart apps |
There was a problem hiding this comment.
How come those changes are included in this PR? Is it by intend or is sth added by accident?
There was a problem hiding this comment.
Ahh stupid me that's the vendored package :3 Forget what I said 🙈
|
Container team will merge this as we need to align it w/ other changes. Putting a request changes review to block merging by accident. |
m3co-code
requested changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.