LBAAS: add tls cipher policy as load balanacer arg#1687
Merged
kishlay-singh-DO merged 1 commit intodigitalocean:mainfrom Apr 29, 2025
Merged
Conversation
| LoadBalancerNetworkStackDualstack = "DUALSTACK" | ||
|
|
||
| // Supported TLS Cipher policies | ||
| LoadBalancerTLSCipherPolicyDefault = "DEFAULT" |
Contributor
There was a problem hiding this comment.
Hey @jvasilevsky I was looking at the API docs for Load balancers and it seems there we allow 3 values for tls cipher policy (STRONG, WEAK & DEFAULT) but in the code we are allowing only 2 values (STRONG & DEFAULT). Can you please look into this?
Contributor
Author
There was a problem hiding this comment.
Let me update the API docs. The Weak value can be assigned, but it currently does not do anything/is equivalent to default. Let me remove it from the api docs.
kishlay-singh-DO
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ability to set load balancer tls cipher policy via doctl