Retrieve version from the correct spot #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the method for retrieving the ADK version to use package metadata instead of accessing a module-level attribute. This change improves reliability by querying the installed package metadata directly, preventing potential issues where the module attribute might be incorrect or unavailable.
Changes:
- Replaced direct
gradient_adk.__version__access with a new_get_adk_version()helper function - Added
importlib.metadataimport to retrieve version from package metadata - Implemented graceful fallback to "unknown" when package metadata is unavailable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JLee21
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retrieves the ADK version from the correct metadata and ensures that it gets sent to the deploy service correctly. The previous version could produce wrong result.