feat(IBAN): Automatic Bank Name identification and controlled form inputs#3694
Open
Spencer6497 wants to merge 27 commits into
Open
feat(IBAN): Automatic Bank Name identification and controlled form inputs#3694Spencer6497 wants to merge 27 commits into
Spencer6497 wants to merge 27 commits into
Conversation
aaschlote
reviewed
May 12, 2026
Contributor
aaschlote
left a comment
aaschlote
left a comment
There was a problem hiding this comment.
I added a few comments — this looks promising overall. I think there are still some improvements we could make, but we can address them later after discussing the comments below.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new pattern to forms: form inputs controlling other form inputs. In this example, when a user enters a valid IBAN that corresponds to an existing bank, the IbanInput field updates the bankName field with the matched name. This has wider application, for example, entering a Postleitzahl and automatically filling the city.