message_test.c:main() memory leak

dilyanpalauzov · Aug 21, 2023 · 15a17c0 · 15a17c0
1 parent 2fffdc5
commit 15a17c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/imap/message.h b/imap/message.h
@@ -285,7 +285,7 @@ extern message_t *message_new_from_index(struct mailbox *,
                                          const struct index_record *,
                                          uint32_t msgno,
                                          uint32_t indexflags);
-extern message_t *message_new_from_filename(const char *filename);
+__attribute__((malloc, nonnull, returns_nonnull, warn_unused_result)) extern message_t *message_new_from_filename(const char *filename);
 extern void message_set_from_data(const char *base, size_t len,
                                   message_t *m);
 extern void message_set_from_mailbox(struct mailbox *mailbox,

diff --git a/imap/message_test.c b/imap/message_test.c
@@ -259,17 +259,15 @@ int main(int argc, char **argv)
         mailbox_close(&mailbox);
     }
     else if (filename) {
-        message_t *message = NULL;
+        message_t *message = message_new_from_filename(filename);
 
-        message = message_new_from_filename(filename);
         r = dump_message(message);
+        message_unref(&message);
         if (r) {
             fprintf(stderr, "Error dumping message: %s\n",
                     error_message(r));
             return 1;
         }
-
-        message_unref(&message);
     }
     else {
         message_t *message = NULL;