Skip to content

Commit

Permalink
Remove support for NTLM
Browse files Browse the repository at this point in the history
As it is removed upstream from cyrus-sasl
cyrusimap/cyrus-sasl@60f2b06
  • Loading branch information
dilyanpalauzov committed Mar 23, 2024
1 parent fda0d0a commit 8044d61
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 13 deletions.
4 changes: 2 additions & 2 deletions docsrc/imap/download/installation/manage-dav.rst
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ authentication does not depend on a Cyrus SASL plugin.

The advertisement of the other HTTP authentication schemes is controlled by the
:ref:`SASL mech_list option <cyrussasl:options>` option. For Cyrus httpd
the GSS-SPNEGO, NTLM, SCRAM-SHA-1, and SCRAM-SHA-256 values enable
support for the Negotiate (Kerberos only), NTLM, SCRAM-SHA-1, and
the GSS-SPNEGO, SCRAM-SHA-1, and SCRAM-SHA-256 values enable
support for the Negotiate (Kerberos only), SCRAM-SHA-1, and
SCRAM-SHA-256 authentication schemes respectively, provided that the plugins
are installed on the server.

Expand Down
2 changes: 0 additions & 2 deletions docsrc/imap/rfc-support.rst
Original file line number Diff line number Diff line change
Expand Up @@ -959,8 +959,6 @@ draft-murchison-lmtp-ignorequota

LMTP Service Extension for Ignoring Recipient Quotas

[MS-NTHT] NTLM Over HTTP Protocol Specification

draft-ietf-sieve-regex

Sieve Email Filtering -- Regular Expression Extension
Expand Down
2 changes: 1 addition & 1 deletion imap/http_proxy.c
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ static int login(struct backend *s, const char *userid,
serverin = base64;
}

/* SASL mech (SCRAM-*, Digest, Negotiate, NTLM) */
/* SASL mech (SCRAM-*, Digest, Negotiate) */
r = sasl_client_step(s->saslconn, serverin, serverinlen,
NULL, /* no prompts */
&clientout, &clientoutlen);
Expand Down
4 changes: 1 addition & 3 deletions imap/httpd.c
Original file line number Diff line number Diff line change
Expand Up @@ -451,8 +451,6 @@ struct auth_scheme_t auth_schemes[] = {
{ AUTH_SCRAM_SHA1, "SCRAM-SHA-1", "SCRAM-SHA-1",
AUTH_NEED_PERSIST | AUTH_SERVER_FIRST | AUTH_BASE64 |
AUTH_REALM_PARAM | AUTH_DATA_PARAM },
{ AUTH_NTLM, "NTLM", "NTLM",
AUTH_NEED_PERSIST | AUTH_BASE64 },
{ AUTH_BEARER, "Bearer", NULL,
AUTH_SERVER_FIRST | AUTH_REALM_PARAM },
AUTH_SCHEME_BASIC,
Expand Down Expand Up @@ -4302,7 +4300,7 @@ static int http_auth(const char *creds, struct transaction_t *txn)
httpd_authstate = auth_newstate(user);
}
else {
/* SASL-based authentication (SCRAM_*, Digest, Negotiate, NTLM) */
/* SASL-based authentication (SCRAM_*, Digest, Negotiate) */
const char *serverout = NULL;
unsigned int serveroutlen = 0;
unsigned int auth_params_len = 0;
Expand Down
7 changes: 3 additions & 4 deletions imap/httpd.h
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,9 @@ struct auth_scheme_t {
enum {
AUTH_BASIC = (1<<0),
AUTH_SPNEGO = (1<<1),
AUTH_NTLM = (1<<2),
AUTH_BEARER = (1<<3),
AUTH_SCRAM_SHA1 = (1<<4),
AUTH_SCRAM_SHA256 = (1<<5)
AUTH_BEARER = (1<<2),
AUTH_SCRAM_SHA1 = (1<<3),
AUTH_SCRAM_SHA256 = (1<<4)
};

/* Auth scheme flags */
Expand Down
2 changes: 1 addition & 1 deletion imtest/imtest.c
Original file line number Diff line number Diff line change
Expand Up @@ -2703,7 +2703,7 @@ static void usage(char *prog, char *prot)
else if (!strcasecmp(prot, "nntp"))
printf(" (\"user\" for AUTHINFO USER/PASS\n");
else if (!strcasecmp(prot, "http"))
printf(" (\"basic\", \"digest\", \"negotiate\", \"ntlm\")\n");
printf(" (\"basic\", \"digest\", \"negotiate\")\n");
printf(" -f file : pipe file into connection after authentication\n");
printf(" -r realm : realm\n");
#ifdef HAVE_SSL
Expand Down

0 comments on commit 8044d61

Please sign in to comment.