Closed
Conversation
OrangeAndGreen
requested changes
Jul 17, 2024
Contributor
OrangeAndGreen
left a comment
OrangeAndGreen
left a comment
There was a problem hiding this comment.
Summarizing some main themes from the comments:
- The allowPassword stuff in biometric config is gone on purpose, so that code can go away
- Some confusion in the behavior when user needs to configure fingerprint/PIN
- CONNECT_UNLOCK_BIOMETRIC and ConnectIdBiometricUnlockActivity should both be going away
…re-android into pm_CCCT_356 # Conflicts: # app/AndroidManifest.xml # app/res/values/strings.xml # app/src/org/commcare/activities/connect/ConnectIdBiometricConfigActivity.java # app/src/org/commcare/connect/ConnectIdWorkflows.java
Contributor
|
@pm-dimagi Curious what happened here, the PR is not merge but the related ticets are marked as done. Do we need this PR to be merged or this can be closed ? |
Contributor
Author
|
@shubham1g5 this pr can be closed as changes related to this are already in qa branch and some changes are skipped so we can close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove extra page of biometric implemented the new design for the same
Tickets
https://dimagi.atlassian.net/browse/CCCT-349
https://dimagi.atlassian.net/browse/CCCT-355
https://dimagi.atlassian.net/browse/CCCT-356
Feature Flag
Product Description
Safety Assurance
Automated test coverage
Safety story