-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XML compression #27022
XML compression #27022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -31,6 +32,8 @@ def new(self, **blob_meta_args): | |||
"keyword arguments are incompatible with `meta` argument") | |||
return blob_meta_args["meta"] | |||
timeout = blob_meta_args.pop("timeout", None) | |||
if blob_meta_args.get('type_code') == CODES.form_xml: | |||
blob_meta_args['compressed_length'] = -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like this. It does got overwritten during later but still feels off
Make the error more generic so it can be used in other places if need be. Currently this error is never expected to occur unless there is a bug.
Both GzipStream and GzipStream.Buffer had a `_buf` attribute. The class composition made it easy to confuse the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed some bugs and created a new PR against the original branch in @satyaakam's fork: satyaakam#1
@snopoke I'm not sure how you were able to push directly to this PR since it's originating from a fork. I'd be interested in learning how you did that.
Gzip stream fixes for XML compression
I got given write access to the forked repo |
@millerdev build is passing but will let you do a final review before merging |
Flagging that this PR incorrectly updated the commcare-translations submodule reverting it back to an older 2.47 version. @orangejenny has made the required correction on master pushing it back to the latest commit. |
https://dimagi-dev.atlassian.net/browse/IIO-742
SUMMARY
Changes in BlobDB API were made as per the suggestions on #26813
FEATURE FLAG
ICDS-CAS
PRODUCT DESCRIPTION
None