Get table name directly #35724
Merged
Get table name directly #35724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetching the table to get its name is more work than needed and can cause issues if the table configuration isn't valid resolves COMMCAREHQ-DREX COMMCAREHQ-DRFG
3 tasks
ajeety4
reviewed
Feb 3, 2025
| @@ -65,7 +65,8 @@ def get_existing_table_from_db(self): | |||
|
|
|||
| @property | |||
| def table_exists(self): | |||
| return self.engine.has_table(self.get_table().name) | |||
| table_name = _get_table_name_for_adapter(self.override_table_name, self.config) | |||
ajeety4
approved these changes
Feb 3, 2025
kaapstorm
approved these changes
Feb 3, 2025
|
Going to put this on staging and let it be there for a while before I consider merging this. |
mkangia
added
product/feature-flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
No visible change to users
Technical Summary
Fetching the table to get its name is more work than needed and can cause issues if the table configuration isn't valid
resolves COMMCAREHQ-DREX & COMMCAREHQ-DRFG
Feature Flag
USER_CONFIGURABLE_REPORTSSafety Assurance
Safety story
Tested locally
Automated test coverage
QA Plan
Rollback instructions
Labels & Review