Fix broken links due to ga parameter #35760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
Risk: High
jingcheng16
requested review from
esoergel,
orangejenny and
biyeun
as code owners
jingcheng16
added
the
product/all-users-all-environments
orangejenny
approved these changes
Feb 12, 2025
corehq/apps/hqwebapp/templates/hqwebapp/includes/bootstrap3/modal_eula.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Jenny Schweers <[email protected]>
orangejenny
approved these changes
Feb 12, 2025
|
Still in discussion with marketing, so holding on the merge of this PR |
|
Close since marketing fixed the issue from wordpress/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Ticket: https://dimagi.atlassian.net/browse/SAAS-16518
Summary of the issue: https://docs.google.com/document/d/1VsJMDeW6hrF70wJ0WdCmPF5Cz1cz9wk0TQO8a1zXOks/edit?tab=t.0#heading=h.609dr5lptgfa
TLDR:
The redirection broken due to the google analytics parameter added to the url.
Instead of using:
https://dimagi.com/terms/latest/privacy/
https://dimagi.com/terms/latest/tos/
https://dimagi.com/terms/latest/aup/
https://dimagi.com/terms/latest/ba/
We will replace them directly in the codebase with their redirected versions:
https://dimagi.com/terms-privacy/
https://dimagi.com/terms-of-service/
https://dimagi.com/terms-aup/
https://dimagi.com/terms-ba/
🐠 Review by commit
Feature Flag
Safety Assurance
Safety story
Only update urls.
Automated test coverage
QA Plan
Rollback instructions
Labels & Review