Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Workflow #68

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

CI Workflow #68

wants to merge 20 commits into from

Conversation

hemant10yadav
Copy link
Contributor

@hemant10yadav hemant10yadav commented Jan 8, 2025

This PR introduces the following changes: CCCT-637

  • Adds django-environ to load environment variables.
  • Includes ci.yml configuration for running pytest in CI.
  • Adds linting configurations.

Additionally, follow the branches below to view formatting and pytest fixes:

  • Formatting changes: #69
  • Test fixes: #70

@hemant10yadav hemant10yadav changed the title configs CI-workflow Jan 8, 2025
@hemant10yadav hemant10yadav changed the title CI-workflow CI Workflow Jan 8, 2025
@hemant10yadav hemant10yadav mentioned this pull request Jan 8, 2025
Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few changes but this looks very close

Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few changes still missing, but getting closer

@sravfeyn
Copy link
Member

Apart from some minor comments, looks good. It will be nice to update any READMEs on local setup to copy using env_template instead of example localsettings.

@hemant10yadav
Copy link
Contributor Author

Apart from some minor comments, looks good. It will be nice to update any READMEs on local setup to copy using env_template instead of example localsettings.

I will update the README as well.

@calellowitz
Copy link
Collaborator

Looks like tests are still failing, but otherwise looks good.

@hemant10yadav
Copy link
Contributor Author

hemant10yadav commented Jan 23, 2025

Looks like tests are still failing, but otherwise looks good.

@calellowitz I have fixed the test in #69 and #70

Copy link
Member

@sravfeyn sravfeyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! G2G once the test failure is addressed

@hemant10yadav
Copy link
Contributor Author

hemant10yadav commented Feb 26, 2025

@calellowitz @sravfeyn @pxwxnvermx
FYI- I have merged the test fix #70 and linting fixes #69 branch, pulled the latest changes, and encountered a failing test along with a minor linting issue due to recent updates in the main branch. I have fixed these in my last commit: 45dc450

Also there is a issue raised by CodeQL as we are logging user phone_number here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants