-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Django 4.2 #72
Conversation
- no longer runs tests against 3.7 as it as been EOLed
Update: I read through breaking changes introduced in 4.0 and feel confident that django-prbac is not relying on any of these. I'm thinking of updating the allowed django versions in this PR as well. Any thoughts @millerdev? |
👍 Sounds good to me. |
- support python 3.8 - 3.11 - support django 3 and 4, drop support for 2
I realized that the "tests passing on 4.2" before was due to
There were a couple of changes in Django 4 that needed to be addressed here:
I've addressed these in this PR as well, so tests for 4.2 now pass. |
Django 4 raises a ValueError when attempting to read a fk relationship on an unsaved model, rather than return an empty list.
Co-authored-by: Daniel Miller <[email protected]>
Reverts ebfcaae and adds line to ignore .python-version
Python 3.7 has been EOLed, so remove that and run against newer versions of Python as well (3.10 and 3.11).
And in anticipation for Django 3.2 being EOLed in April 2024, we should update tests to run against both 3.2 and 4.2 LTS.