Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SceneNode3d and SceneNode2d: Recursive vs Non-Recursive Methods
Methods that previously modified both a node and all its descendants now only modify the current node.
Use the new
_recursivesuffix variants for the previous behavior.Renamed methods (now non-recursive by default):
SceneNode3d:set_material,set_material_with_nameset_color,set_texture,set_texture_from_file,set_texture_from_memory,set_texture_with_nameset_lines_width,set_lines_color,set_points_size,set_points_colorset_surface_rendering_activation,enable_backface_cullingset_local_scale,set_visibleset_metallic,set_roughness,set_emissiveset_normal_map,set_normal_map_from_file,set_normal_map_from_memory,set_normal_map_with_nameset_ao_map,set_ao_map_from_file,set_ao_map_from_memory,set_ao_map_with_nameset_emissive_map,set_emissive_map_from_file,set_emissive_map_from_memory,set_emissive_map_with_namemodify_vertices,read_vertices,recompute_normals,modify_normals,read_normalsmodify_uvs,read_uvs,modify_faces,read_facesSceneNode2d:set_material,set_material_with_nameset_color,set_texture,set_texture_from_file,set_texture_from_memory,set_texture_with_nameset_lines_width,set_lines_color,set_points_size,set_points_colorset_surface_rendering_activationset_local_scale,set_visiblemodify_vertices,read_vertices,modify_uvs,read_uvs,modify_faces,read_facesNew recursive variants:
All the above methods now have
_recursivesuffix versions (e.g.,set_color_recursive) that apply to the node and all descendants.Helper method renames:
apply_to_objects_mut→apply_to_objects_mut_recursive/apply_to_object_mut(new)apply_to_objects→apply_to_objects_recursive/apply_to_object(new)apply_to_scene_nodes_mut→apply_to_scene_nodes_mut_recursiveapply_to_scene_nodes→apply_to_scene_nodes_recursive