Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use builtin CEDET by default #2502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

npostavs
Copy link
Collaborator

@MHOOO wrote at 85eca62#commitcomment-20000437

Isnt el-get supposed to stay up-to-date, instead of using builtins?

There's not really a hard rule about it, but since CEDET has been builtin since 23.3 which is earlier than the earliest Emacs we support anyway, probably anyone installing it would want the git version. Somehow I didn't think of it when I merged that change.

This broke my config, since cedet is no longer being loaded from git.

I will a wait bit before merging to see if anyone else has some comments about this, but you can add (:name cedet :builtin nil) to el-get-sources to fix this in the meantime.


Users installing CEDET via el-get probably wanted the git version.  For
those who want the builtin, they can add (:name cedet :builtin "23.3")
to `el-get-sources'.

Also move the :post-init block to :prepare so that the :lazy nil hack
becomes redundant.

Users installing CEDET via el-get probably wanted the git version.  For
those who want the builtin, they can add (:name cedet :builtin "23.3")
to `el-get-sources'.

Also move the :post-init block to :prepare so that the :lazy nil hack
becomes redundant.
@xuhdev
Copy link
Contributor

xuhdev commented Dec 6, 2016

The reason I proposed to add a builtin keyword is that when I tried to install something depending on CEDET, el-get also tries to install the latest version for me which causes problems on older versions of Emacs. My guess is that CEDET has been too integrated into Emacs that non-latest Emacs versions may not be officially supported.

@npostavs
Copy link
Collaborator Author

npostavs commented Dec 6, 2016

Hmm, so it sounds like using the builtin CEDET breaks some configs, and using the git head CEDET breaks others. I'm not sure what the default should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants