Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create method 'gitlab'. #2605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create method 'gitlab'. #2605

wants to merge 1 commit into from

Conversation

gavk
Copy link

@gavk gavk commented Jan 16, 2018

No description provided.

@gavk
Copy link
Author

gavk commented Jan 16, 2018

It took the recipe 'mo-git-blame', but the repository moved to https://gitlab.com. First I wanted to change the recipe type to 'git', but I decided to do it like 'github'.

@@ -14,5 +14,5 @@ script:
- byte-compile pkg/*.el
- byte-compile -Werror *.el methods/*.el
- ert-tests
- check-recipes -Wno-features -Wno-github -Wno-autoloads recipes/
- check-recipes -Wno-features -Wno-github -Wno-gitlab -Wno-autoloads recipes/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's just six recipes using gitlab urls right now, maybe we should just change them all to :type gitlab?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. In addition to the existing 6 recipes, there is also "mo-git-blame", which moved to gitlab.
type git => type gitlab
url "https://gitlab.com/warsaw/winring.git" => pkgname "warsaw/winring"

@yyr
Copy link
Collaborator

yyr commented Dec 31, 2018

I wonder why we need separate zip tar methods for gitlab? can't we just only clone the package from gitlab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants