Create method 'gitlab'. #2605
Open
Create method 'gitlab'. #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It took the recipe 'mo-git-blame', but the repository moved to https://gitlab.com. First I wanted to change the recipe type to 'git', but I decided to do it like 'github'. |
npostavs
reviewed
Jan 17, 2018
| @@ -14,5 +14,5 @@ script: | |||
| - byte-compile pkg/*.el | |||
| - byte-compile -Werror *.el methods/*.el | |||
| - ert-tests | |||
| - check-recipes -Wno-features -Wno-github -Wno-autoloads recipes/ | |||
| - check-recipes -Wno-features -Wno-github -Wno-gitlab -Wno-autoloads recipes/ | |||
There was a problem hiding this comment.
It looks like there's just six recipes using gitlab urls right now, maybe we should just change them all to :type gitlab?
There was a problem hiding this comment.
Yes. In addition to the existing 6 recipes, there is also "mo-git-blame", which moved to gitlab.
type git => type gitlab
url "https://gitlab.com/warsaw/winring.git" => pkgname "warsaw/winring"
|
I wonder why we need separate zip tar methods for gitlab? can't we just only clone the package from gitlab? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.