Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to use functions at git's :commit option #2679

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added ability to use functions at git's :commit option #2679

wants to merge 2 commits into from

Conversation

zilti
Copy link
Contributor

@zilti zilti commented Jan 31, 2019

Concerning issue #2482

Now, two questions:

  1. Is this a good approach?
  2. Should the function take an argument that denotes the VCS used so this change can be added to others like Mercurial, or are there better ways to figure out the VCS?

@zilti
Copy link
Contributor Author

zilti commented Feb 5, 2019

This is still work in progress. Actually, el-get-start-process-list is giving me some headaches. What would the preferred way be to use a return value from one process in the list in the next?

@npostavs
Copy link
Collaborator

npostavs commented Feb 5, 2019

2. Should the function take an argument that denotes the VCS used so this change can be added to others like Mercurial, or are there better ways to figure out the VCS?

Yeah, I think passing at least the type would make sense. Perhaps even the whole recipe, to be "future proof"? (might be overkill though)

Actually, el-get-start-process-list is giving me some headaches. What would the preferred way be to use a return value from one process in the list in the next?

I don't think you can use el-get-start-process-list that way.

@zilti
Copy link
Contributor Author

zilti commented Feb 5, 2019

I think passing the name and the method would suffice, since if the recipe is needed, it can be fetched using el-get-package-def.

I could modify el-get-start-process-list so that if an entry is a lambda instead of a list, that lambda gets passed the return value of the last process?

@npostavs
Copy link
Collaborator

I could modify el-get-start-process-list so that if an entry is a lambda instead of a list, that lambda gets passed the return value of the last process?

Hmm, a lambda is also a list, so this could get messy. How about starting with just a plain call-process and see about making asynch if needed later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants