Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update oef-mode.rcp #2825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update oef-mode.rcp #2825

wants to merge 1 commit into from

Conversation

raoulhatterer
Copy link
Contributor

request removed

@raoulhatterer
Update oef-mode.rcp
606a3e4 
request removed
@raoulhatterer
Copy link
Contributor Author

Hello
I don't understand how pull request are working.
I want to merge so I made a pull request but, until now, the code I unchanged.
Is there anything else I have to do for that or just wait ?

@stephan-cr
Copy link
Contributor

You can't merge yourself, all you can do is wait. You should also clarify your description. Not sure what the other oef-mode PRs are about, namely #2807, #2821 and #2822. This should be clarified as well. Maybe you could simply close those, which are not required.

@raoulhatterer
Copy link
Contributor Author

Thank you very much for your answer.
I have problem with some request (auctex) so I removed all request to see if the basic install process is going well. l will close the oldest pull request as you suggest.

alexott
alexott reviewed Dec 24, 2021
View reviewed changes
recipes/oef-mode.rcp
@@ -2,5 +2,4 @@
:description "Provide oef-mode (Online Exercise Format for WIMS) to emacs"
:type github
:pkgname "raoulhatterer/oef-mode"
:depends (emmet-mode company-mode rainbow-delimiters rainbow-mode yafolding auctex wrap-region expand-region cl-lib)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really useful to remove dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raoulhatterer @stephan-cr @alexott