Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to use password auth as md5 #335

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cpj2195
Copy link
Contributor

@cpj2195 cpj2195 commented Jun 21, 2023

No description provided.

@hanefi
Copy link
Contributor

hanefi commented Oct 16, 2023

I do not see the value of this PR. Is there any harm in setting POSTGRES_HOST_AUTH_METHOD=trust in a test environment?

@dimitri
Copy link
Owner

dimitri commented Oct 16, 2023

I do not see the value of this PR. Is there any harm in setting POSTGRES_HOST_AUTH_METHOD=trust in a test environment?

I think the idea was that we used to have a problem with parsing connection strings longer than MAXCONNINFO, a static length provided by libpq, size 1024 bytes. We wanted to make sure that with some long authentication entries we would still be able to parse the connection string and connect. Meanwhile I believe we have fixed that issue, but making sure we're good on that front is a good idea.

That said we might be able to only change a couple of the unit test cases (with and without logical decoding) to have regression testing support in that area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants