Fix docker compose external volume #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In unit tests where we use both an inject and a test services, we need the inject service to access the same pgcopydb work directory as the test service. For that we use an external docker volume. The previous implementation of that idea was found to be wrong, this is fixing it by properly using docker APIs for shared "external" volumes.
The sharing is necessary for the follow-* tests where an inject service is being used in the background, concurrently to the main test service.
On my local environment docker volume create turned out to not be necessary, which is good news because we can (and probably want to) keep the volumes around between test rounds. A cleanup script has even been implemented to restart fresh. On GitHub actions, it looks like we might need to first create the docker volume to then be able to use it. The error message is not very helpful (it just says: docker-compose: no such file or directory), but it's worth trying that.
This runs an interactive docker container (bash) with the volume mounted for exploration / debug / inspect.
dimitri
force-pushed
the
fix/docker-compose-external-volume
branch
from
6d43b08
to
80bc34b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In unit tests where we use both an inject and a test services, we need the
inject service to access the same pgcopydb work directory as the test
service. For that we use an external docker volume.
The previous implementation of that idea was found to be wrong, this is
fixing it by properly using docker APIs for shared "external" volumes.