Merged
Conversation
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Good.
Some discrepancies found:
Q1:
Stage 1: Distribution is not binomial. It is uniform random selection without replacement, which is equivalent to hypergeometric.
Stage 2: “Sampling with replacement” is incorrect. Each infected person undergoes one independent Bernoulli trial.
Q2: Your intuition in the last sentence the standard error/noise decreases exponentially (sorry I'm not explaining this well). is right. You probably want to say that the noise decreases with the number of repetitions, consistent with the Law of large numbers (not exponentially)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completing the Sampling assignment with one edit to the code.
What did you learn from the changes you have made?
I learnt how to identify sample type, population, distribution, and how to determine what a code might mean in reference to sampling.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I followed the assignment's instructions and completed the assignment in VSCode using python packages.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The major challenge was understanding the code. I haven't coded before, and we didn't go over how sampling would look like as a code (practical). So that was a major challenge. Otherwise, just needed to read up on sampling.
How were these changes tested?
The simulation was run with the code block.
A reference to a related issue in your repository (if applicable)
N/A
Checklist