Merged
Conversation
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ❌ | rawdata not moved to data/raw |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ❌ | No server log files in data/raw |
| Part 1 - Q6 | ❌ | No user log files in data/raw; No event log files in data/raw |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ❌ | rawdata not moved to data/raw |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
anjali-deshpande-hub
approved these changes
Oct 11, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Well done!
Question 2: You could have done the same using single command mv ./rawdata ./data/raw. Remember that the mv command can be used to move as well as rename files/directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. adding or removing code, refactoring existing code, adding reports)
I added code to organize and move directories/files, resulting in creating new folders, moving data/files, filtering by specificnames/extensions, and cleaning up sensitive files/
What did you learn from the changes you have made?
I learned how to use basic shell commands like
mkdir,mv,cp,rm, andfind, and how to be specific in giving my arguments.Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I followed the assignment's instructions and completed the assignment in git bash (with script edits in VS Code).
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I ran into a bit of a contradiction between the instructions and the autograder.
Step 2 said to move the entire rawdata directory into ./data/raw — which I did with:
mv ./rawdata ./data/rawFollowed by Step 5 (and similarly for Step 6) as:
cp ./data/raw/rawdata/*server*.log ./data/processed/server_logsBut when I did that, Steps 5 and 6 failed because the server/user/event log files end up inside ./data/raw/rawdata, while the autograder seems to look for them directly in ./data/raw.
To make Step 5+6 pass, I instead moved the contents of rawdata into ./data/raw using:
mv ./rawdata/* ./data/rawWhich made step 5 (and similarly for step 6):
cp ./data/raw/ *server*.log ./data/processed/server_logsThis change made Steps 5 and 6 pass, but then Step 2 failed because the directory (./rawdata) itself wasn’t moved into ./data/raw. I tested both versions, and both scripts run correctly with their specific modifications.
Eventually, I decided to move the whole ./rawdata into ./data/raw and then up-move the contents of the rawdata into ./data/raw, resulting in:
And kept Steps 5 and 6 as:
cp ./data/raw/ *server*.log ./data/processed/server_logsThis workaround satisfied all the conditions of the autograder.
How were these changes tested?
I tested the script initially with
bash assignment.shto see if all conditions were met and the script ran properly.Then I checked if all directories were created and files moved as needed (with
ls)I verified that my removed files were actually gone.
And I finally checked the inventory.txt (using
cat)A reference to a related issue in your repository (if applicable)
See "Shell Trial2", "Shell Trial3", and "Shell Trial move whole then up"
Checklist