Merged
Conversation
anjali-deshpande-hub
approved these changes
Nov 15, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Very well done! 68/70
There is only problem in the Section 3 - Update query. The result set obtained from the running the query is incorrect. The bug is a sneaky one!! Please see the attached screenshot.

The inner MAX(market_date) subquery illegally references vi, which is not in scope inside that subquery. vi is only defined in the outer subquery. vi does not exist in the scope of the inner SELECT max(...). So, the reference vi.product_id is invalid. To fix the bug, you will have to replace vi.product_id with product_id at line 272.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I made logic data models, used various queries in sql, and reflected on the ethical implications of LLMs.
What did you learn from the changes you have made?
I learnt how to work in sql with more complexity and how to structure multiple types of queries and what outputs they gave (COALESCE, windowed functions, ranking, string manipulation, UNION, Cross Join, INSERT, DELETE, UPDATE). I also learnt how to make a logic data model for a database from scratch, including what the keys are and how to assess relations between tables.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I followed the assignment's instructions and completed the sql assignment in DB Browser.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The major challenge for me was getting used to the SQL syntax and nesting multiple functions within a query. Google and Stack Overflow were very helpful, and otherwise just practising on a few different conditions I created for myself from the database. But I definitely still need to practise a lot more!
How were these changes tested?
The codes were run in relation to the farmer's market database, and I checked most outputs by going into the actual table and manually filtering/calculating.
A reference to a related issue in your repository (if applicable)
N/A
Checklist