Add hash column to directus_files that updates only when replacing an existing file
#22751
+464
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2be2411 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
that1matt
force-pushed
the
fix-22606
branch
3 times, most recently
from
6dbbed3
to
89c27c6
Compare
that1matt
force-pushed
the
fix-22606
branch
5 times, most recently
from
2d52b6f
to
aad7064
Compare
rijkvanzanten
requested changes
Jun 25, 2024
that1matt
commented
Jun 26, 2024
that1matt
commented
Jun 26, 2024
that1matt
force-pushed
the
fix-22606
branch
2 times, most recently
from
9dd63a0
to
4b4ef89
Compare
that1matt
force-pushed
the
fix-22606
branch
3 times, most recently
from
fa4b621
to
5c009af
Compare
api/src/database/migrations/20240613A-add-files-version-field.ts
Outdated
Show resolved
Hide resolved
api/src/database/migrations/20240613A-add-files-version-field.ts
Outdated
Show resolved
Hide resolved
that1matt
changed the title
version column to directus_files that updates when using the Replace File toggle.version column to directus_files that updates only when replacing an existing file
that1matt
force-pushed
the
fix-22606
branch
2 times, most recently
from
00889bf
to
5bc392c
Compare
This comment has been minimized.
This comment has been minimized.
that1matt
commented
Jun 27, 2024
that1matt
commented
Jun 27, 2024
that1matt
changed the title
version column to directus_files that updates only when replacing an existing filereplaced_on column to directus_files that updates only when replacing an existing file
that1matt
commented
Jun 28, 2024
that1matt
changed the title
replaced_on column to directus_files that updates only when replacing an existing filehash column to directus_files that updates only when replacing an existing file
Co-authored-by: Hannes Küttner <[email protected]>
Co-authored-by: Hannes Küttner <[email protected]>
…en replacing existing file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
directus_filesnow includes ahashcolumn that gets updated when using theReplace Filetoggle.Potential Risks / Drawbacks
v-upload.vuejust yet.v-upload.vuefiles.tsserviceReview Notes / Questions
readableStreamToStringhappens after the file is processed to prevent a race condition withsharp. Would love to get some extra eyes on the tests to make sure they are valid and complete.Fixes #22606