Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: add wrapper to run scripts by invoking the scripts module #111

Merged
merged 4 commits into from
Nov 14, 2021

Conversation

onerandomusername
Copy link
Member

Description

Because there are so many upcoming scripts, (GH-75, GH-89) this adds a way to be able to shorten the interface to launch a script.

Rather than use python -m scripts.export_requirements, python -m scripts export_reqs can be used. Internally, scripts.export_requirements thinks it has been called the same way as if it was called directly.

This script can be thought of as a launcher for the scripts within the scripts module.

@onerandomusername onerandomusername added p: normal Normal Priority s: needs review Ready for review and merge a: tools Development related to our toolchain (Docker, poetry, flake8) t: chore Maintainence fix labels Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #111 (5a2a2e3) into main (92356fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   70.72%   70.72%           
=======================================
  Files          33       33           
  Lines        1602     1602           
  Branches      190      190           
=======================================
  Hits         1133     1133           
  Misses        438      438           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92356fd...5a2a2e3. Read the comment docs.

Copy link
Member

@Shivansh-007 Shivansh-007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it as a task, otherwise LGTM!

to add scripts to the alias system, put them in the commands dictionary
this is apparently what click uses as the program description in the help menu
@onerandomusername onerandomusername added the skip changelog Skip the need for a changelog entry for a Pull Request label Nov 14, 2021
@onerandomusername onerandomusername merged commit 7c7a589 into main Nov 14, 2021
@onerandomusername onerandomusername deleted the scripts-wrapper branch November 14, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tools Development related to our toolchain (Docker, poetry, flake8) p: normal Normal Priority s: needs review Ready for review and merge skip changelog Skip the need for a changelog entry for a Pull Request t: chore Maintainence fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants