Feat/plugin install #69
Open
Commits on Aug 27, 2021
Commits on Aug 28, 2021
-
major: refactor plugin and addon structure
plugins can now be created as a type of addon adds regexes to convert from a repo or zip to a plugin with a source tests nearly all of the added code.
-
-
Commits on Aug 29, 2021
Commits on Aug 30, 2021
Commits on Sep 1, 2021
-
chore: move plugin_helpers to modmail/plugins
Moving plugin_helpers to a file within the plugin class means that it can be used with `from modmail.plugins` rather than use the weird plugin_helpers name that it previously had.
-
-
Commits on Sep 5, 2021
-
minor: remove admins from being able to manage plugins
This permission can be restored once it is able to check permissions on a designated guild This could be used by people adding the bot if a user makes the bot public by mistake
-
-
-
-
-
-
-
-
Commits on Sep 6, 2021
Commits on Sep 7, 2021
-
plugins: refactor to allow local plugins
local plugins now act mostly like normal plugins. they do not have any special names, and exist as if they were installed normally to add a local plugin, put the files in the plugins folder, in a normal folder, and create a local.toml file in the same format as plugins.toml for addon repositories.
-
-
Commits on Sep 8, 2021
Commits on Sep 9, 2021
-
major: plugin loading error handling and proper replies
plugin management handles more errors and validation helper class in modmail.utils.responses to send success or fail messages
Commits on Sep 10, 2021
Commits on Sep 11, 2021
-
breaking: restructure how extensions are stored
major EXT_METADATA improvements
-
implement partial plugin restructure
restructure plugin variables to be a global list of plugins with the extensions as an attribute
-
-
-
Commits on Sep 12, 2021
Commits on Sep 13, 2021
Commits on Sep 15, 2021
Commits on Sep 16, 2021
Commits on Sep 21, 2021
Commits on Sep 23, 2021
Commits on Nov 17, 2021
Commits on Nov 18, 2021
-
-
-
fix: patch plugin folder during tests
fixes issue with testing environment differing if the user has custom plugins resolved by monkeypatching the modmail.plugin module to be believed to be in a different location this keeps the plugins consistent between environments
-
Commits on Nov 19, 2021
-
-
-
-
-
-
fix: mark failing test as xfail
this is too involved to fix right now Solution involves returning zip files, but the changes to do that require commiting a zipfile, or zipping a zip file before the test. But the contents of that zipfile should be the expected format, so there needs to be several mock files for that. But then they should be in a test resources directory But then the test resources directory should have a few helper methods But then the test resources will need a large amount of review. So the short is, there is a fix for these tests, but it adds a subsystem and is out of scope of this pr.
-
-
Commits on Nov 21, 2021
-
Revert "ci: run tests with verboseness, not quietness"
This reverts commit 1c88421. Not part of the scope of this pr. Also should not have been here but a rebase would change more history than I want to change.
-
-
chore: make requested changes and address review
- don't require future annotations in modmail/addons/converters.py - make all `__all__` tuples - set score cutoff to a constant in modmail/addons/models.py - compress if statements - use {} in place of dict() - fix typos in some docstrings - use correct typehints where they are incorrect - decode the stderr stream only once in pip install - remove unnecessary logging debug statements - restructure finding plugins to be easy to be easier to read - use set() where previously it was {}. This would cause the variable to be of the wrong type
Commits on Feb 24, 2022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.