Drugs call parent on affect_ingest(), removes duplicate definition of affect_blood() #8145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you didn't test it it doesn't work |
Wrong, also, draft cause I decided on possibly porting the WHOLE tg metab system |
|
My brain is going to be so joever after this... |
|
Also this might be a bad PR to implement, it nerfs drugs hard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I started wondering why hyperzine doesn't work on ingest, well, here's why.
/drug/affect_ingest() was not calling parent, meaning the affect_blood() called in /reagent/affect_ingest() was not getting called.
There was also a duplicate definition of affect_blood() for whatever reason, so I removed that.
Why It's Good For The Game
Fixes a long-standing bug (3 years) and removes an useless piece of code.
Testing
Compiles, no other testing done.
This can't cause any new bugs.
...don't quote me on that.
Changelog
🆑
fix: Drugs work properly on ingest.
/:cl: