Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: better release workflow #10325

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Jun 5, 2024

Please describe the changes this PR makes and why it should be merged:

Creates a proper release workflow, works in ci as well as locally.

This

  • determines the release tree
  • releases all packages in scope, or all packages necessary to release the specified package
  • if a package is already released at a version, the registry check will allow it to skip publishing that package
  •  sanity checks publish completion before moving to the next branch of the release tree
  • creates the tag and publishes a release on github

Status and versioning classification:

@ckohen ckohen requested review from a team and iCrawl as code owners June 5, 2024 12:47
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2024 10:36am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2024 10:36am

@ckohen ckohen requested review from Jiralite and almeidx June 6, 2024 08:01
@ckohen ckohen force-pushed the ci/better-release branch 2 times, most recently from 8880b32 to 536eeef Compare June 8, 2024 01:16
@ckohen ckohen requested a review from Jiralite June 8, 2024 01:21
kyranet
kyranet previously requested changes Jun 9, 2024
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, pressed the wrong button 😅

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 311 lines in your changes missing coverage. Please review.

Project coverage is 49.36%. Comparing base (ba0cb66) to head (ac1b284).

Files Patch % Lines
...actions/src/releasePackages/generateReleaseTree.ts 0.00% 225 Missing ⚠️
...ages/actions/src/releasePackages/releasePackage.ts 0.00% 86 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10325      +/-   ##
==========================================
- Coverage   50.10%   49.36%   -0.75%     
==========================================
  Files         228      230       +2     
  Lines       20533    20844     +311     
  Branches     1236     1238       +2     
==========================================
  Hits        10289    10289              
- Misses      10199    10510     +311     
  Partials       45       45              
Flag Coverage Δ
brokers 64.14% <ø> (ø)
builders 95.79% <ø> (ø)
collection 99.32% <ø> (ø)
formatters 99.31% <ø> (ø)
guide 0.00% <ø> (ø)
proxy 78.52% <ø> (ø)
rest 92.68% <ø> (ø)
util 68.86% <ø> (ø)
utilities 5.47% <0.00%> (-94.53%) ⬇️
voice 63.64% <ø> (ø)
website 0.00% <ø> (ø)
ws 51.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ckohen ckohen requested a review from vladfrangu June 19, 2024 13:39
- name: Pubish packages
uses: ./packages/actions/src/releasePackages
with:
exclude: 'create-discord-bot,@discordjs/docgen'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we exclude create-discord-bot from dev releases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, this is the existing workflow though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was leaned away from because it's not a package like the others in a traditional sense and it has no documentation. I would be impartial to it having development releases.

packages/actions/src/releasePackages/index.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

None yet

5 participants