-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: better release workflow #10325
base: main
Are you sure you want to change the base?
ci: better release workflow #10325
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
8880b32
to
536eeef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, pressed the wrong button 😅
Co-authored-by: Aura <[email protected]>
Co-authored-by: Vlad Frangu <[email protected]>
970c52e
to
d526ed9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10325 +/- ##
==========================================
- Coverage 50.10% 49.36% -0.75%
==========================================
Files 228 230 +2
Lines 20533 20844 +311
Branches 1236 1238 +2
==========================================
Hits 10289 10289
- Misses 10199 10510 +311
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
da71777
to
637266d
Compare
- name: Pubish packages | ||
uses: ./packages/actions/src/releasePackages | ||
with: | ||
exclude: 'create-discord-bot,@discordjs/docgen' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we exclude create-discord-bot from dev releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question, this is the existing workflow though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was leaned away from because it's not a package like the others in a traditional sense and it has no documentation. I would be impartial to it having development releases.
Please describe the changes this PR makes and why it should be merged:
Creates a proper release workflow, works in ci as well as locally.
This
Status and versioning classification: