Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: polls overhaul #10328

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

feat: polls overhaul #10328

wants to merge 27 commits into from
+316 −36

Conversation

uhKevinMC
Copy link
Contributor

@uhKevinMC uhKevinMC commented Jun 6, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

This PR resolves Issue #10326 and adds methods and properties found in similarly structured classes. This also creates a new manager, dubbed the PollAnswerVoterManager to store users that voted for the poll answer, similar to ReactionUserManager for users that reacted to a reaction.

This PR also patches a bug related to poll expiry dates being nullish in the future when polls have the option not to expire.

please do give feedback on this PR, I don't bite

  • Add Poll Answer Voter/User Manager
  • Add partials for Poll and PollAnswer
  • Add support for partials Poll and PollAnswer in respective events
  • Add typings for new properties, methods, classes, and partials
  • Add tests
  • Case testing
  • Sanity check
  • Finalize PR

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 30, 2024 10:45am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 30, 2024 10:45am

@Jiralite Jiralite marked this pull request as ready for review June 6, 2024 07:15
@Jiralite Jiralite requested a review from a team as a code owner June 6, 2024 07:15
@Jiralite Jiralite marked this pull request as draft June 6, 2024 07:15
@Jiralite Jiralite added this to the discord.js 14.16 milestone Jun 6, 2024
@Jiralite Jiralite linked an issue Jun 7, 2024 that may be closed by this pull request
Emit poll events on uncached messages #10326
Open
@uhKevinMC uhKevinMC marked this pull request as ready for review June 8, 2024 08:14
@uhKevinMC
Copy link
Contributor Author

I'm not able to test this locally, gotta love yarn..

Feedback on this would be appreciated!

almeidx
almeidx requested changes Jun 27, 2024
View reviewed changes
packages/discord.js/src/structures/Poll.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Poll.js Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/client/actions/MessagePollVoteRemove.js Outdated Show resolved Hide resolved
packages/discord.js/src/client/actions/MessagePollVoteAdd.js Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/managers/PollAnswerVoterManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/PollAnswerVoterManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/PollAnswerVoterManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Poll.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@almeidx almeidx Awaiting requested review from almeidx

@Jiralite Jiralite Awaiting requested review from Jiralite

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
packages:discord.js semver:minor
Projects
discord.js
Status: Review in Progress
Milestone
discord.js 14.16
Development

Successfully merging this pull request may close these issues.

Emit poll events on uncached messages
3 participants
@uhKevinMC @Jiralite @almeidx