FIX: show non-restricted ads instead of not showing ads at all #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases where there were category restricted house ads we were not showing ads on reload. This commit filter out all the ads that should not be shown on current page, leaving only allowed ads. So now we'll show ads on every reload in all the cases. Internal ticket: t130920
ZogStriP
reviewed
Jun 27, 2024
ZogStriP
approved these changes
Jun 27, 2024
|
Hello, after this commit my users are experiencing JS errors on the House ad part, please find the stacktrace. 
Thanks! |
nicolasblanco
added a commit
to nicolasblanco/discourse-adplugin
that referenced
this pull request
Jul 4, 2024
discourse#213)" This reverts commit 9b72130.
|
@nicolasblanco I have a PR up with the fix: #214 However, I am unable to repro this issue on my dev server. Do you have repro steps (exact settings to configure) for this issue so that I dig even deeper? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases where there were category restricted house ads we were not showing ads on reload. This commit filter out all the ads that should not be shown on current page, leaving only allowed ads. So now we'll show ads on every reload in all the cases.
Internal ticket: t130920