Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: avoid deprecated replace_flag API #57

Merged
merged 2 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .discourse-compatibility
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
< 3.3.0.beta3-dev: d83344a719c21615690c620d2ddb98b5b1ca3cd8
< 3.3.0.beta1-dev: f0792d8bd3a275330045175cb064d5524f47dc11
3.1.999: 50177ed0e00b8e2c744267b727fb05784f0d4776
29 changes: 29 additions & 0 deletions db/migrate/20240527061406_add_malicious_file_score_type.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# frozen_string_literal: true

class AddMaliciousFileScoreType < ActiveRecord::Migration[7.0]
def change
result = DB.query <<~SQL
SELECT MAX(position) FROM flags
SQL

position = result.last&.max

result = DB.query <<~SQL
INSERT INTO flags(name, name_key, applies_to, score_type, position, created_at, updated_at)
lis2 marked this conversation as resolved.
Show resolved Hide resolved
VALUES ('Malicious File', 'malicious_file', '{}', true, #{position.to_i + 1}, NOW(), NOW())
RETURNING flags.id
SQL

new_score_id = result.last&.id

DB.exec <<~SQL
UPDATE reviewable_scores rs1
SET reviewable_score_type = #{new_score_id}
FROM reviewable_scores rs2
LEFT JOIN reviewables ON reviewables.id = rs2.reviewable_id
WHERE rs2.reason = 'malicious_file'
AND reviewables.type = 'ReviewableUpload'
AND rs1.id = rs2.id
SQL
end
end
2 changes: 0 additions & 2 deletions plugin.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@

register_reviewable_type ReviewableUpload

replace_flags(settings: PostActionType.flag_settings, score_type_names: %i[malicious_file])

add_to_serializer(
:site,
:clamav_unreacheable,
Expand Down