Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Modernize codebase #2

Merged
merged 4 commits into from
Jan 13, 2025
Merged

DEV: Modernize codebase #2

merged 4 commits into from
Jan 13, 2025

Conversation

keegangeorge
Copy link
Member

@keegangeorge keegangeorge commented Jan 10, 2025

This theme-component was recently moved from my personal profile (/keegangeorge/discourse-copy-post) to the Discourse org profile. Along with that move, we want to make some modernizations to prepare this theme-component to become #official. This PR handles those modernizations.

In particular we:

  • update linting, configs, workflows, etc.
  • remove widget in favour of Glimmer .gjs component
  • update API usage to use valueTransformer instead of decorateWidget to add the post menu button
  • make improvements to behaviour by way of introducing new settings:
    • choosing between Markdown / HTML for the copied post
    • using allowed_groups setting instead of trust level setting
  • remove acceptance test in favour of system spec

@keegangeorge keegangeorge marked this pull request as ready for review January 13, 2025 17:41
@keegangeorge keegangeorge merged commit 02f1983 into main Jan 13, 2025
3 checks passed
@keegangeorge keegangeorge deleted the dev-modernize branch January 13, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants