Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Removes out-of-date install script mentions #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DEV: Removes out-of-date install script mentions #51

wants to merge 1 commit into from
+49 −62

Conversation

brrusselburg
Copy link

I put up a PR to update something in the install-ruby repo, but CVX noticed how out-of-date the files were. We are archiving that repo, so this PR updates the installation docs to remove any mention or links to the scripts.

@brrusselburg brrusselburg changed the title DEV: Removes out-of-date install scripts DEV: Removes out-of-date install script mentions Apr 3, 2025
CvX
CvX reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@CvX CvX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think it's safe to remove: - [Bundler][bundler_link] from all three docs
  2. could you also update - Node to Node.js (and link to https://nodejs.org/en)
  3. there's also unused phantom_link, docker_guide, and short_name links at the bottom

@brrusselburg brrusselburg force-pushed the br/update_install_doc branch from b56def0 to d17a3f6 Compare April 3, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brrusselburg @CvX