FEATURE: Add following feed to /filter
#148
Merged
+165
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `following-feed:<username>` to the `/filter` endpoint It returns the topics from the users that the current user is following(topics from the `/my/follow/feed` page).
ZogStriP
reviewed
Mar 25, 2025
plugin.rb
Outdated
| next scope if user.nil? | ||
| next scope.none if user.id != guardian.user.id && !guardian.user.staff? | ||
|
|
||
| topic_ids = UserFollower.posts_for(user, current_user: guardian.user).map { |p| p.topic_id } |
There was a problem hiding this comment.
Any chances we could write this as an SQL query instead of loading all the posts model in Ruby-land just to retrieve the topic ids?
There was a problem hiding this comment.
I've added a topics_for but I had thought of just adding:
topic_ids =
UserFollower
.posts_for(user, current_user: guardian.user)
.select("DISTINCT topic_id")
.pluck(:topic_id)But posts_for preloads posts so...
But I can change if you want
create tests for it and update `/filter` to use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
following-feed:<username>to the/filterendpointIt returns the recent topics from the users that the current user follows (topics from the
/my/follow/feedpage).Requires discourse/discourse#31908 to be merged