Skip to content

Commit

Permalink
DEV: Update linting (#47)
Browse files Browse the repository at this point in the history
  • Loading branch information
davidtaylorhq committed Mar 28, 2024
1 parent be58ade commit 34cdb57
Show file tree
Hide file tree
Showing 11 changed files with 288 additions and 152 deletions.
6 changes: 5 additions & 1 deletion javascripts/discourse/components/kanban/card.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { tracked } from "@glimmer/tracking";
import { hash } from "@ember/helper";
import { on } from "@ember/modifier";
import { action } from "@ember/object";
import { inject as service } from "@ember/service";
import { service } from "@ember/service";
import { htmlSafe } from "@ember/template";
import PluginOutlet from "discourse/components/plugin-outlet";
import TopicStatus from "discourse/components/topic-status";
Expand Down Expand Up @@ -116,10 +116,12 @@ export default class KanbanCard extends Component {
{{/if}}

{{#if @topic.indirectly_assigned_to}}
{{! eslint-disable no-unused-vars }}{{! workaround https://github.com/ember-cli/eslint-plugin-ember/issues/2118 }}
{{#each-in
@topic.indirectly_assigned_to
as |target_id assignment|
}}
{{! eslint-enable no-unused-vars }}
{{! template-lint-disable no-nested-interactive }}
<div class="assigned-to">
<a href="/t/{{@topic.id}}/{{assignment.post_number}}">
Expand Down Expand Up @@ -153,10 +155,12 @@ export default class KanbanCard extends Component {
{{/if}}

{{#if @topic.indirectly_assigned_to}}
{{! eslint-disable no-unused-vars }}{{! workaround https://github.com/ember-cli/eslint-plugin-ember/issues/2118 }}
{{#each-in
@topic.indirectly_assigned_to
as |target_id assignment|
}}
{{! eslint-enable no-unused-vars }}
{{htmlSafe
(renderAvatar
assignment.assigned_to
Expand Down
2 changes: 1 addition & 1 deletion javascripts/discourse/components/kanban/controls.gjs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Component from "@glimmer/component";
import { fn } from "@ember/helper";
import { action } from "@ember/object";
import { inject as service } from "@ember/service";
import { service } from "@ember/service";
import DButton from "discourse/components/d-button";
import bodyClass from "discourse/helpers/body-class";
import i18n from "discourse-common/helpers/i18n";
Expand Down
2 changes: 1 addition & 1 deletion javascripts/discourse/components/kanban/list.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Component from "@glimmer/component";
import { tracked } from "@glimmer/tracking";
import { on } from "@ember/modifier";
import { action } from "@ember/object";
import { inject as service } from "@ember/service";
import { service } from "@ember/service";
import { modifier } from "ember-modifier";
import concatClass from "discourse/helpers/concat-class";
import { popupAjaxError } from "discourse/lib/ajax-error";
Expand Down
6 changes: 3 additions & 3 deletions javascripts/discourse/components/kanban/modal/options.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { tracked } from "@glimmer/tracking";
import { fn, hash } from "@ember/helper";
import { action } from "@ember/object";
import { equal } from "@ember/object/computed";
import { inject as service } from "@ember/service";
import { service } from "@ember/service";
import DButton from "discourse/components/d-button";
import DModal from "discourse/components/d-modal";
import DiscourseURL from "discourse/lib/url";
Expand Down Expand Up @@ -86,7 +86,7 @@ export default class KanbanOptionsController extends Component {
@onChange={{fn (mut this.mode)}}
@valueProperty="id"
@nameProperty="id"
@class="kanban-mode-chooser"
class="kanban-mode-chooser"
/>
</div>

Expand All @@ -98,7 +98,7 @@ export default class KanbanOptionsController extends Component {
@allowCreate={{false}}
@filterPlaceholder={{i18n (themePrefix "modal.tags_placeholder")}}
@everyTag={{true}}
@class="kanban-tag-chooser"
class="kanban-tag-chooser"
/>
{{else if this.isCategories}}
<MultiSelect
Expand Down
2 changes: 1 addition & 1 deletion javascripts/discourse/components/kanban/nav.gjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Component from "@glimmer/component";
import { inject as service } from "@ember/service";
import { service } from "@ember/service";
import concatClass from "discourse/helpers/concat-class";
import i18n from "discourse-common/helpers/i18n";
import { displayConnector } from "../../lib/kanban-utilities";
Expand Down
2 changes: 1 addition & 1 deletion javascripts/discourse/components/kanban/wrapper.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { tracked } from "@glimmer/tracking";
import { action } from "@ember/object";
import didInsert from "@ember/render-modifiers/modifiers/did-insert";
import { schedule } from "@ember/runloop";
import { inject as service } from "@ember/service";
import { service } from "@ember/service";
import { modifier } from "ember-modifier";
import DButton from "discourse/components/d-button";
import bodyClass from "discourse/helpers/body-class";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Component from "@glimmer/component";
import { inject as service } from "@ember/service";
import { service } from "@ember/service";
import DiscourseKanban from "../../components/kanban/wrapper";

export default class KanbanBoard extends Component {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { next } from "@ember/runloop";
import { inject as service } from "@ember/service";
import { service } from "@ember/service";
import { withPluginApi } from "discourse/lib/plugin-api";
import discourseComputed from "discourse-common/utils/decorators";
import DiscourseKanbanControls from "../components/kanban/controls";
Expand Down
2 changes: 1 addition & 1 deletion javascripts/discourse/services/kanban-manager.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { tracked } from "@glimmer/tracking";
import { get } from "@ember/object";
import Service, { inject as service } from "@ember/service";
import Service, { service } from "@ember/service";
import Category from "discourse/models/category";
import buildAssignedLists from "../lib/kanban-list-builders/assigned";
import buildCategoryLists from "../lib/kanban-list-builders/categories";
Expand Down
10 changes: 3 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
{
"name": "discourse-kanban-theme",
"version": "1.0.0",
"repository": "https://github.com/discourse/discourse-kanban-theme",
"author": "Discourse",
"license": "MIT",
"private": true,
"devDependencies": {
"@discourse/lint-configs": "^1.3.1",
"@discourse/lint-configs": "^1.3.7",
"ember-template-lint": "^5.13.0",
"eslint": "^8.55.0",
"eslint": "^8.56.0",
"prettier": "^2.8.8"
}
}
Loading

0 comments on commit 34cdb57

Please sign in to comment.