Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernise theme implementation #35

Merged
merged 18 commits into from
Oct 9, 2023
Merged

Modernise theme implementation #35

merged 18 commits into from
Oct 9, 2023

Conversation

davidtaylorhq
Copy link
Member

@davidtaylorhq davidtaylorhq commented Oct 5, 2023 •
edited

  • Glimmer components / @tracked
  • Use new renderInOutlet API
  • New modal API
  • Avoid modifyClass on discovery controllers
  • Add support for tag and tag/category routes
  • Add 'copy link' button to boards
  • Add 'empty state' UX to prompt for configuration

@davidtaylorhq davidtaylorhq changed the title Updates Modernise Implementation Oct 5, 2023
@davidtaylorhq davidtaylorhq changed the title Modernise Implementation Modernise theme implementation Oct 6, 2023
@davidtaylorhq davidtaylorhq marked this pull request as ready for review October 9, 2023 08:32
jjaffeux
jjaffeux approved these changes Oct 9, 2023
View reviewed changes
Copy link

@jjaffeux jjaffeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 Ideally we would have few sanity tests to ensure it's not all broken, it would help future dev to get started with some confidence.

@davidtaylorhq davidtaylorhq merged commit 25373cf into main Oct 9, 2023
3 checks passed
@davidtaylorhq davidtaylorhq deleted the updates branch October 9, 2023 11:15
davidtaylorhq added a commit that referenced this pull request Oct 12, 2023
@davidtaylorhq
Revert "Modernise discourse-kanban-theme implementation (#35)"
a6f1366 
This reverts commit 25373cf. Some installs on `3.2.0.beta2-dev` do not actually have gjs support, so we can't safely make this change until beta2 is fully released. Once that's done, we can re-merge this change with a `<beta2` compat entry.
davidtaylorhq added a commit that referenced this pull request Oct 12, 2023
@davidtaylorhq
Revert "Modernise discourse-kanban-theme implementation (#35)" (#37)
a008b2f 
This reverts commit 25373cf. Some installs on `3.2.0.beta2-dev` do not actually have gjs support, so we can't safely make this change until beta2 is fully released. Once that's done, we can re-merge this change with a `<beta2` compat entry.
Arkshine added a commit to Arkshine/discourse-kanban-theme that referenced this pull request Nov 24, 2023
@Arkshine
Modernise discourse-kanban-theme implementation (discourse#35)
aedc333 
Highlights include:
- Glimmer components / @Tracked
- Use new renderInOutlet API
- New modal API
- Avoid modifyClass on discovery controllers
- Add support for tag and tag/category routes
- Add 'copy link' button to boards
- Add 'empty state' UX to prompt for configuration
- Add system specs
davidtaylorhq added a commit that referenced this pull request Nov 25, 2023
@davidtaylorhq
Revert "Revert "Modernise discourse-kanban-theme implementation (#35)" (
c0e446f 
#37)"

This reverts commit a008b2f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjaffeux jjaffeux jjaffeux approved these changes

@ZogStriP ZogStriP ZogStriP left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@davidtaylorhq @jjaffeux @ZogStriP