-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernise theme implementation #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaffeux
reviewed
Oct 9, 2023
jjaffeux
reviewed
Oct 9, 2023
jjaffeux
reviewed
Oct 9, 2023
jjaffeux
reviewed
Oct 9, 2023
jjaffeux
reviewed
Oct 9, 2023
jjaffeux
reviewed
Oct 9, 2023
jjaffeux
reviewed
Oct 9, 2023
jjaffeux
reviewed
Oct 9, 2023
jjaffeux
reviewed
Oct 9, 2023
jjaffeux
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍 Ideally we would have few sanity tests to ensure it's not all broken, it would help future dev to get started with some confidence.
jjaffeux
reviewed
Oct 9, 2023
ZogStriP
reviewed
Oct 9, 2023
ZogStriP
reviewed
Oct 9, 2023
jjaffeux
reviewed
Oct 9, 2023
ZogStriP
reviewed
Oct 9, 2023
ZogStriP
reviewed
Oct 9, 2023
ZogStriP
reviewed
Oct 9, 2023
davidtaylorhq
added a commit
that referenced
this pull request
Oct 12, 2023
This reverts commit 25373cf. Some installs on `3.2.0.beta2-dev` do not actually have gjs support, so we can't safely make this change until beta2 is fully released. Once that's done, we can re-merge this change with a `<beta2` compat entry.
davidtaylorhq
added a commit
that referenced
this pull request
Oct 12, 2023
This reverts commit 25373cf. Some installs on `3.2.0.beta2-dev` do not actually have gjs support, so we can't safely make this change until beta2 is fully released. Once that's done, we can re-merge this change with a `<beta2` compat entry.
Arkshine
added a commit
to Arkshine/discourse-kanban-theme
that referenced
this pull request
Nov 24, 2023
Highlights include: - Glimmer components / @Tracked - Use new renderInOutlet API - New modal API - Avoid modifyClass on discovery controllers - Add support for tag and tag/category routes - Add 'copy link' button to boards - Add 'empty state' UX to prompt for configuration - Add system specs
davidtaylorhq
added a commit
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tracked
renderInOutlet
API