Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Update for glimmer topic-list #29

Merged
merged 2 commits into from
Jan 13, 2025
Merged

DEV: Update for glimmer topic-list #29

merged 2 commits into from
Jan 13, 2025

Conversation

davidtaylorhq
Copy link
Member

@davidtaylorhq davidtaylorhq commented Jan 13, 2025

@@ -1,3 +1,4 @@
{{!-- has-modern-replacement --}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a "smart" comment? Or just a note for future travellers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a magic comment which silences the deprecation message, and allows the new-topic-list to be auto-enabled 🚀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, TIL!

@davidtaylorhq davidtaylorhq merged commit 2b90066 into main Jan 13, 2025
3 checks passed
@davidtaylorhq davidtaylorhq deleted the gtl branch January 13, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants