DEV: Use new addSaveableUserField plugin API #54
+26
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify preference saving by using the new
`addSaveableUserField(name, { page: "emails" })` API.
This replaces manual value transformer registration and backward
compatibility code with a single declarative API call.
cf. discourse/discourse#36757
pmusaraj
approved these changes
Dec 17, 2025
The PreferenceCheckbox component doesn't properly propagate checkbox state changes back to the model when used in plugin outlet contexts. This caused the subscription preference to not be saved when users toggled the checkbox. Replace PreferenceCheckbox with a native checkbox element and an explicit @action handler that calls model.set() when the checkbox changes. This ensures the model value is properly updated before the preferences are saved to the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify preference saving by using the new
addSaveableUserField(name, { page: "emails" })API.This replaces manual value transformer registration and backward compatibility code with a single declarative API call.
cf. discourse/discourse#36757