FIX: don't use fallback key as button text (#55)

javascripts/discourse/components/search-banner.js

@@ -40,7 +40,16 @@ export default class SearchBanner extends Component {
   }
 
   get buttonText() {
-    return I18n.t(themePrefix("search_banner.search_button_text"));
+    const buttonText = I18n.t(themePrefix("search_banner.search_button_text"));
+    // this is required for when the English (US) locale is empty
+    // and the site locale is set to another language
+    // otherwise the English (US) fallback key is rendered as the button text
+    // https://meta.discourse.org/t/bug-with-search-banner-search-button-text-shown-in-search-banner-theme-component/273628
+    if (buttonText.includes("theme_translations")) {
+      return false;
+    }
+
+    return buttonText;
   }
 
   get shouldDisplay() {