FEATURE: Show 'marked solved by' in OP when topic is solved #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs to be edited to merge into |
nattsw
force-pushed
the
show-accepter
branch
5 times, most recently
from
032d75b to
cf89d97
Compare
nattsw
force-pushed
the
custom-fields-to-table
branch
from
b6c14fb to
75ad157
Compare
nattsw
commented
Mar 24, 2025
| { cooked: hasExcerpt ? withExcerpt : withoutExcerpt }, | ||
| dec | ||
| ); | ||
| const cooked = new PostCooked({ cooked: solvedQuote }, dec); |
There was a problem hiding this comment.
The need for functionality within PostCooked here is why we can't yet switch to a glimmer component, so we will just update the widget as-is for now.
tgxworld
reviewed
Mar 25, 2025
tgxworld
reviewed
Mar 25, 2025
Comment on lines
+44
to
+46
| if !SiteSetting.enable_names || !SiteSetting.display_name_on_posts | ||
| accepted_answer[:name] = nil | ||
| accepted_answer[:accepter_name] = nil |
There was a problem hiding this comment.
This comment is tied to my other comment. We are already handling some of the logic here so could centralize them in a single place.
tgxworld
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #342
This feature adds the "Marked solved as" information to the solved post appended to OP.
Note to reviewer: Originally, I had moved the widget usage to a component, but due to "cooking quotes", after some internal discussion (t/95318/25) we will stick to widgets for now as the post-stream gets modernized.
Desktop
Mobile